Introduced FormEmailService façade and struggling with names again

Following the advice given by One on a comment, I introduced a façade service that encapsulate everything about emails, FormEmailService with FormEmailComposer and EmailSender as collaborators. This simplified the creation of the IntroducedInformation class which was great.

I also followed his suggestion of passing the form object as a parameter to the sendByEmailAndRedirect method.

This was how it was used after that change:

	<?php
	$info =
	IntroducedInfoBuilder::aNewIntroducedInformation()
	->onPage("empresas")
	->toBeSentTo("xxx@ppp.es")
	->build();
	$info->sendByEmailAndRedirect(new Form($_POST));

view raw otherUse.php hosted with ❤ by GitHub

Although the creation of the IntroducedInformation got simpler, I didn't like how it read anymore because an "information thing" was now sending a form.

In the previous version the "information thing" was sending itself using a "Yoda-like" language:

	<?php
	$info =
	IntroducedInfoBuilder::aNewIntroducedInformation()
	->onPage("empresas")
	->toBeSentTo("xxx@ppp.es")
	->build();
	$info->sendByEmailAndRedirect();

view raw use3.php hosted with ❤ by GitHub

To keep the form as a parameter I decided to rename the class to so it was "something that does something on something" and not finding any better name I went down the road of "SomethingService" names:

	<?php
	$service =
	EmailAndRedirectServiceBuilder::aServiceToSendByEmail()
	->aFormOnPage("empresas")
	->to("xxx@ppp.es")
	->build();
	$service->sendAndRedirect(new Form($_POST));

view raw use4.php hosted with ❤ by GitHub

Well, it's not perfect but at least I think it reads better than the version where the "information thing" was sending a form.

This is how the class looks now:

	<?php
	class EmailAndRedirectService
	{
	private $redirection;
	private $emailService;
	function __construct(
	FormEmailService $emailService,
	Redirection $redirection
	) {
	$this->emailService = $emailService;
	$this->redirection = $redirection;
	}
	public function sendAndRedirect($form)
	{
	if ($form->isNotFilled()) {
	$this->redirection->backToInitialPage();
	return;
	}
	$email = $this->createEmail($form);
	$sendingSucceeded = $this->send($email);
	$this->redirect($sendingSucceeded);
	}
	private function redirect($sendingSucceeded)
	{
	if ($sendingSucceeded) {
	$this->redirection->toSuccessPage();
	} else {
	$this->redirection->toFailPage();
	}
	}
	private function createEmail($form)
	{
	return $this->emailService->composeEmailFrom($form);
	}
	private function send(Email $email)
	{
	return $this->emailService->send($email);
	}
	}

view raw EmailAndRedirectService.php hosted with ❤ by GitHub

and these are its tests:

	<?php
	class EmailAndRedirectServiceTest extends PHPUnit_Framework_TestCase
	{
	private $form;
	private $redirection;
	private $emailAndRedirectService;
	private $email;
	private $formEmailService;
	function setUp()
	{
	$this->redirection = Phake::mock('Redirection');
	$this->email = new Email("from", "to", "subject", "message");
	$this->form = Phake::mock('Form');
	$this->formEmailService = Phake::mock('FormEmailService');
	$this->emailAndRedirectService =
	new EmailAndRedirectService(
	$this->formEmailService,
	$this->redirection
	);
	}
	function testRedirectionBackToFormPage()
	{
	$this->whenFormNotFilled();
	$this->emailAndRedirectService->sendAndRedirect($this->form);
	Phake::verify($this->redirection)
	->backToInitialPage();
	}
	function testEmailComposition()
	{
	$this->whenFormFilledWithWhateverFields();
	$this->andEmailGetsComposed();
	$this->emailAndRedirectService->sendAndRedirect($this->form);
	Phake::verify($this->formEmailService)
	->composeEmailFrom($this->form);
	}
	function testEmailSending()
	{
	$this->whenFormFilledWithWhateverFields();
	$this->andEmailGetsComposed();
	$this->emailAndRedirectService->sendAndRedirect($this->form);
	Phake::verify($this->formEmailService)
	->send($this->email);
	}
	function testRedirectionToSuccesPage()
	{
	$this->whenFormFilledWithWhateverFields();
	$this->andEmailGetsComposed();
	$this->andIsSentSuccessfully();
	$this->emailAndRedirectService->sendAndRedirect($this->form);
	Phake::verify($this->redirection)->toSuccessPage();
	}
	function testRedirectionToFailPage()
	{
	$this->whenFormFilledWithWhateverFields();
	$this->andEmailGetsComposed();
	$this->butIsNotSentSuccessfully();
	$this->emailAndRedirectService->sendAndRedirect($this->form);
	Phake::verify($this->redirection)->toFailPage();
	}
	private function whenFormFilledWithWhateverFields()
	{
	Phake::when($this->form)
	->isNotFilled()
	->thenReturn(false);
	}
	private function whenFormNotFilled()
	{
	Phake::when($this->form)
	->isNotFilled()
	->thenReturn(true);
	}
	private function andIsSentSuccessfully()
	{
	Phake::when($this->formEmailService)
	->send($this->email)
	->thenReturn(true);
	}
	private function butIsNotSentSuccessfully()
	{
	Phake::when($this->formEmailService)
	->send($this->email)
	->thenReturn(false);
	}
	private function andEmailGetsComposed()
	{
	Phake::when($this->formEmailService)
	->composeEmailFrom($this->form)
	->thenReturn($this->email);
	}
	}

view raw EmailAndRedirectServiceTest.php hosted with ❤ by GitHub

I keep thinking in a name for this that doesn't follow the "SomethingService" pattern, but until inspiration comes I'll settle on this one.

Thank you very much Carlos, Marcin and José for your feedback. I really appreciate it.